Skip to content

feat: configurable cohere processors destination #2235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 29, 2025
Merged

feat: configurable cohere processors destination #2235

merged 6 commits into from
May 29, 2025

Conversation

grvsahil
Copy link
Contributor

@grvsahil grvsahil commented Apr 2, 2025

Description

  • Made the destination of cohere processors configurable.
  • Updated description of the cohere processors.

Fixes #2231

Quick checks

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@grvsahil grvsahil self-assigned this Apr 2, 2025
@grvsahil grvsahil requested a review from a team as a code owner April 2, 2025 13:24
maha-hajja
maha-hajja reviewed May 6, 2025
View reviewed changes
Copy link
Contributor

@maha-hajja maha-hajja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! added some small nitpicks nothing too big

maha-hajja
maha-hajja approved these changes May 27, 2025
View reviewed changes
Copy link
Contributor

@maha-hajja maha-hajja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@grvsahil grvsahil merged commit caf38c1 into main May 29, 2025
4 checks passed
@grvsahil grvsahil deleted the feat/cohere-processors-destination branch May 29, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maha-hajja maha-hajja maha-hajja approved these changes

Assignees

@grvsahil grvsahil

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: The destination of cohere processors should be configurable
2 participants
@grvsahil @maha-hajja